Move the group of ShadowJar from shadow to build#1355
Conversation
There was a problem hiding this comment.
Code Review
The pull request aims to move the ShadowJar group from shadow to build. This change seems reasonable as it aligns the task grouping with standard Gradle practices. The changes are relatively small and focused. Here's a review with some suggestions.
Summary of Findings
- Task Grouping: The change moves the
ShadowJartask to theLifecycleBasePlugin.BUILD_GROUP, which is a standard Gradle group for build-related tasks. This improves discoverability and consistency.
Merge Readiness
The pull request appears to be in good shape. The changes are small and focused, and the move to the standard BUILD_GROUP seems appropriate. I recommend merging after addressing the minor feedback provided. I am unable to directly approve the pull request, and other reviewers should review and approve this code before merging.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the changelog to document the relocation of the ShadowJar group from shadow to build.
- Updates the changes log by adding a new entry under the "Changed" section.
Files not reviewed (3)
- api/shadow.api: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowBasePlugin.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.kt: Language not supported
Aligns with
Jar,SourceJarTask, and so on.