Simplify ServiceFileTransformer and remove ServiceStream#1218
Merged
Conversation
3678a01 to
57c7895
Compare
Goooler
commented
Jan 30, 2025
| public class ServicesResourceTransformer extends AbstractCompatibilityTransformer { | ||
| private static final String SERVICES_PATH = "META-INF/services"; | ||
|
|
||
| private final Map<String, Set<String>> serviceEntries = new HashMap<>(); |
Member
Author
There was a problem hiding this comment.
This field gets rid of ServiceStream in apache/maven-shade-plugin@c18d3d3.
d70f4a2 to
f47dd0a
Compare
f47dd0a to
6bc263f
Compare
…vice-file-transformer // Conflicts: // src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/ServiceFileTransformer.kt
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (4)
- api/shadow.api: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/ServiceFileTransformer.kt: Language not supported
- src/test/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/ServiceFileTransformerTest.kt: Language not supported
…vice-file-transformer
…vice-file-transformer
ServiceFileTransformerServiceFileTransformer and remove ServiceStream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync logic to