Fixes #3898, log an info instead of o warning when entrypoint makes t…#3904
Conversation
…n entrypoint makes the image to ignore jvm parameters
mpeddada1
left a comment
There was a problem hiding this comment.
Thank you for your contribution @rmannibucau!
| // in a multi-module project it is not rare to configure a ton of jvmflags, sometimes | ||
| // classpath | ||
| // but having a submodule overriding entrypoint and ignoring all that is intended when such a | ||
| // config is done | ||
| // so just log it for user awareness but as an INFO, it is NOT an error |
There was a problem hiding this comment.
nit: Thanks for documenting this! This comment may be better suited as a PR description.
Comments are usually recommended when it is not entirely clear what the code is doing but in this case, the use of LogEvent.info is self-explanatory so it should be safe to omit it.
There was a problem hiding this comment.
Intent was to document it shouldnt be switched to warn in code - not sure anyone would use blame to check that but happy to drop it if you think it is better
There was a problem hiding this comment.
Intent was to document it shouldnt be switched to warn in code -
I see! Increasing the log severity (to warnings or errors) needs to be done thoughtfully regardless so this shouldn't be a major concern. This change would also help us make the style be consistent with other classes in the repo.
|
Kudos, SonarCloud Quality Gate passed! |
mpeddada1
left a comment
There was a problem hiding this comment.
LGTM! Thank you so much @rmannibucau!
…he image to ignore jvm parameters
Before filing a pull request, make sure to do the following:
This helps to reduce the chance of having a pull request rejected.