Fix Gradle deprecations by Sineaggi · Pull Request #3892 · GoogleContainerTools/jib

Sineaggi · 2022-12-12T22:52:31Z

Gradle has deprecated JavaPluginConvention in favor of JavaPluginExtension
The file com.google.cloud.tools.jib.properties is already being generated by the gradle plugin
The compile configuration has been replaced by implementation

sonarqubecloud · 2022-12-13T01:18:54Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

65.0% Coverage
0.0% Duplication

sonarqubecloud · 2023-01-20T16:35:16Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

65.0% Coverage
0.0% Duplication

emmileaf · 2023-02-08T21:16:07Z

@Sineaggi Apologies for the number of PRs that fell off our radar - we will take some time to review them and appreciate your patience!

Sineaggi · 2023-02-08T21:25:19Z

@emmileaf Take your time, and thanks for reaching out!

emmileaf

@Sineaggi Thanks for helping to address these deprecation warnings! I’ve left two quick inline comments below.

emmileaf · 2023-02-11T01:21:11Z

gradle/wrapper/gradle-wrapper.properties

 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-6.9.2-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-6.9.3-bin.zip


Are we able to exclude these gradle wrapper updates and keep the existing version, or is it tied to another aspect of this PR that I am missing?

Nope, it's just bumping gradle to the latest patch version is one of the first things I do when working on deprecation warnings.

Gotcha. If it's not a blocker, could you exclude the files related to gradle build version upgrade, and keep this PR just for the deprecation-related fixes? Thanks!

emmileaf · 2023-02-11T01:21:52Z

build.gradle


  configurations {
    integrationTestImplementation.extendsFrom testImplementation
-    integrationTestImplementation.setCanBeResolved(true)


Ah, I’m curious to what IDE you are using to develop with? Digging back in history a bit (#2961, #2375), I think some of this integrationTestImplementation setup may have been added to work around some Eclipse-specific issues, but I don’t personally use Eclipse for development and don’t have a quick way to confirm. It would be great to know if they no longer causing problems though!

I use Intellij, which didn't need this. If it's required for Eclipse, keeping it seems reasonable.

Let's keep it in if it doesn't hurt.

Sounds good

sonarqubecloud · 2023-04-28T17:11:31Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

65.0% Coverage
0.0% Duplication

sonarqubecloud · 2023-07-07T19:50:35Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

65.0% Coverage
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

mpeddada1 · 2023-07-11T17:01:41Z

Thank you for your contribution @Sineaggi!

Co-authored-by: Clayton Walker <cwalker@sofi.org> Co-authored-by: Emily Wang <emmwang@google.com>

Co-authored-by: Clayton Walker <cwalker@sofi.org> Co-authored-by: Emily Wang <emmwang@google.com> # Conflicts: # build.gradle # jib-cli/build.gradle # jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/GradleProjectProperties.java # jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/JibPlugin.java # jib-gradle-plugin/src/test/java/com/google/cloud/tools/jib/gradle/GradleProjectPropertiesTest.java

Co-authored-by: Clayton Walker <cwalker@sofi.org> Co-authored-by: Emily Wang <emmwang@google.com>

Sineaggi force-pushed the fix-gradle-deprecations branch 5 times, most recently from 6070f10 to 77942a5 Compare December 13, 2022 00:33

Sineaggi force-pushed the fix-gradle-deprecations branch from 53177db to 7223718 Compare January 20, 2023 16:27

emmileaf mentioned this pull request Feb 8, 2023

Use dependency injection in tasks #3897

Open

emmileaf reviewed Feb 11, 2023

View reviewed changes

emmileaf requested a review from mpeddada1 February 11, 2023 01:41

Fix Gradle deprecations

dfc477e

Sineaggi force-pushed the fix-gradle-deprecations branch from 7223718 to dfc477e Compare April 28, 2023 17:06

emmileaf added the kokoro:run label Jul 7, 2023

kokoro-team removed the kokoro:run label Jul 7, 2023

mpeddada1 added the kokoro:force-run label Jul 7, 2023

kokoro-team removed the kokoro:force-run label Jul 7, 2023

Merge branch 'master' into fix-gradle-deprecations

6e97a9d

emmileaf added the kokoro:run label Jul 7, 2023

kokoro-team removed the kokoro:run label Jul 7, 2023

mpeddada1 approved these changes Jul 10, 2023

View reviewed changes

mpeddada1 merged commit 201c810 into GoogleContainerTools:master Jul 11, 2023

Sineaggi deleted the fix-gradle-deprecations branch July 11, 2023 17:12

alicejli mentioned this pull request Jul 11, 2023

Jib Gradle Plugin emits warning on gradle 8.2 due to referencing deprecated convention. #4062

Closed

emmileaf mentioned this pull request Jul 11, 2023

chore: disable gradle parallel build in project properties #4073

Merged

wwadge pushed a commit to wwadge/jib that referenced this pull request Jul 11, 2023

Fix Gradle deprecations (GoogleContainerTools#3892)

1830360

Co-authored-by: Clayton Walker <cwalker@sofi.org> Co-authored-by: Emily Wang <emmwang@google.com>

wwadge pushed a commit to wwadge/jib that referenced this pull request Jul 11, 2023

Fix Gradle deprecations (GoogleContainerTools#3892)

0d6f2f1

Co-authored-by: Clayton Walker <cwalker@sofi.org> Co-authored-by: Emily Wang <emmwang@google.com>

wwadge added a commit to wwadge/jib that referenced this pull request Jul 11, 2023

Fix Gradle deprecations (GoogleContainerTools#3892)

b78c65f

Co-authored-by: Clayton Walker <cwalker@sofi.org> Co-authored-by: Emily Wang <emmwang@google.com>

wwadge added a commit to wwadge/jib that referenced this pull request Jul 11, 2023

Fix Gradle deprecations (GoogleContainerTools#3892)

1a14b0d

Co-authored-by: Clayton Walker <cwalker@sofi.org> Co-authored-by: Emily Wang <emmwang@google.com>

mpeddada1 mentioned this pull request Jul 20, 2023

Upgrade to gradle 8.4, junit 5. Fix configuration cache issues. #4069

Closed

wwadge added a commit to wwadge/jib that referenced this pull request Jul 20, 2023

Fix Gradle deprecations (GoogleContainerTools#3892)

f4eb749

Co-authored-by: Clayton Walker <cwalker@sofi.org> Co-authored-by: Emily Wang <emmwang@google.com>

wwadge added a commit to wwadge/jib that referenced this pull request Sep 5, 2023

Fix Gradle deprecations (GoogleContainerTools#3892)

f6c4727

Conversation

Sineaggi commented Dec 12, 2022

Uh oh!

sonarqubecloud bot commented Dec 13, 2022

Uh oh!

sonarqubecloud bot commented Jan 20, 2023

Uh oh!

emmileaf commented Feb 8, 2023

Uh oh!

Sineaggi commented Feb 8, 2023

Uh oh!

emmileaf left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Apr 28, 2023

Uh oh!

sonarqubecloud bot commented Jul 7, 2023

Uh oh!

mpeddada1 commented Jul 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants