Update OpenTelemetry dependencies #413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit b7c0dc1)
Contributor
|
/gcbrun |
psx95
requested changes
May 22, 2025
Contributor
psx95
left a comment
There was a problem hiding this comment.
Thanks for the PR!
It seems like you need to run ./gradlew spotlessApply to fix some style checks.
...esourcemapping/src/main/java/com/google/cloud/opentelemetry/resource/ResourceTranslator.java
Outdated
Show resolved
Hide resolved
...rcemapping/src/test/java/com/google/cloud/opentelemetry/resource/ResourceTranslatorTest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks @psx95, styling and imports should now be ok! |
Contributor
|
/gcbrun |
Contributor
|
Hi @tschut, the CLA check is failing in the recent commits. Could you fix that ? I think it might be because you added commits that were created using a different email account not covered by the CLA. |
Contributor
Author
Crap. Rewrote a bit of history and I think it's correct now. |
Contributor
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #399