Merged
Conversation
ec138ba to
b065429
Compare
b065429 to
34c99f8
Compare
HKWinterhalter
approved these changes
Dec 11, 2024
matthewrobertson
added a commit
that referenced
this pull request
Dec 12, 2024
matthewrobertson
added a commit
that referenced
this pull request
Dec 12, 2024
zymotik
reviewed
Feb 11, 2025
| }, | ||
| "dependencies": { | ||
| "@types/express": "4.17.21", | ||
| "@types/express": "^5.0.0", |
There was a problem hiding this comment.
I see Express v4 referenced in dependencies, so the v5 types here are causing compatibility issues when used in other libraries. See issue #673.
Should types also be moved to devDependencies?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated all dependencies and fixed resulting broken tests.
Unfortunately, we are still stuck on some older versions of packages until we completely drop support for nodejs10 and nodejs12 in 2025.
BEGIN_COMMIT_OVERRIDE
deps: update all dependencies
END_COMMIT_OVERRIDE