Skip to content

fix: Update buildpack-integration-test.yml#165

Merged
akerekes merged 2 commits intomainfrom
akerekes-patch-2
Feb 7, 2025
Merged

fix: Update buildpack-integration-test.yml#165
akerekes merged 2 commits intomainfrom
akerekes-patch-2

Conversation

@akerekes
Copy link
Copy Markdown
Contributor

@akerekes akerekes commented Feb 7, 2025

Add ${{ inputs.builder-runtime }} to the name for artifact upload. This will avoid the conflict in names, where e.g. php81, php82 and php83 will try to upload the artifacts with the same name and the second and later attempts will fail:

Run actions/upload-artifact@v4
  with:
    name: cloudevent_buildpack_integ_logs
    path: /tmp/ff_*
    retention-days: 5
    if-no-files-found: warn
    compression-level: 6
    overwrite: false
    include-hidden-files: false
With the provided path, there will be 2 files uploaded
Artifact name is valid!
Root directory input is valid!
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

https://github.com/GoogleCloudPlatform/functions-framework-php/actions/runs/13191006742/job/36867920300

Add ${{ inputs.builder-runtime }} to the `name` for artifact upload. This will avoid the conflict in names, where e.g. php81, php82 and php83 will try to upload the artifacts with the same name and the second and later attempts will fail:

```
Run actions/upload-artifact@v4
  with:
    name: cloudevent_buildpack_integ_logs
    path: /tmp/ff_*
    retention-days: 5
    if-no-files-found: warn
    compression-level: 6
    overwrite: false
    include-hidden-files: false
With the provided path, there will be 2 files uploaded
Artifact name is valid!
Root directory input is valid!
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
```

https://github.com/GoogleCloudPlatform/functions-framework-php/actions/runs/13191006742/job/36867920300
change uploaded artifact name based on whether a builder-url is specified or not
@akerekes akerekes merged commit a95b422 into main Feb 7, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants