fix: Update buildpack-integration-test.yml#165
Merged
Conversation
Add ${{ inputs.builder-runtime }} to the `name` for artifact upload. This will avoid the conflict in names, where e.g. php81, php82 and php83 will try to upload the artifacts with the same name and the second and later attempts will fail:
```
Run actions/upload-artifact@v4
with:
name: cloudevent_buildpack_integ_logs
path: /tmp/ff_*
retention-days: 5
if-no-files-found: warn
compression-level: 6
overwrite: false
include-hidden-files: false
With the provided path, there will be 2 files uploaded
Artifact name is valid!
Root directory input is valid!
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
```
https://github.com/GoogleCloudPlatform/functions-framework-php/actions/runs/13191006742/job/36867920300
change uploaded artifact name based on whether a builder-url is specified or not
dixuswe
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ${{ inputs.builder-runtime }} to the
namefor artifact upload. This will avoid the conflict in names, where e.g. php81, php82 and php83 will try to upload the artifacts with the same name and the second and later attempts will fail:https://github.com/GoogleCloudPlatform/functions-framework-php/actions/runs/13191006742/job/36867920300