core(trace-engine-result): disable invalidations handler#16142
Merged
core(trace-engine-result): disable invalidations handler#16142
Conversation
connorjclark
reviewed
Aug 5, 2024
connorjclark
reviewed
Aug 5, 2024
adamraine
commented
Aug 5, 2024
This reverts commit 7fb1689.
connorjclark
approved these changes
Aug 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Lighthouse-side symptoms of #16111
Since we don't use the invalidations handler in Lighthouse anywhere it should be safe to disable it. There is still the possibility of high memory usage in the performance panel though.
Also upgrades the trace engine package to 0.0.30