core(third-party-summary): correct blocking time calculation#16117
Merged
core(third-party-summary): correct blocking time calculation#16117
Conversation
connorjclark
approved these changes
Jul 19, 2024
connorjclark
approved these changes
Aug 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15184
The problem with the old method was we were doing a
- 50msoperation on tasks that were not top level. These tasks do contribute to blocking time if their root task is longer than 50ms, even if they aren't larger than 50ms themselves.The TBT impact numbers account for this by interpolating the impact of child tasks on the blocking time of the root task. This PR reuses this interpolation logic (in
calculateTbtImpactForEvent) except it ignores the TBT bounds by usingInfinityvalues.