Conversation
adamraine
commented
Jun 10, 2024
| // The expectation here is tuned for ToT Chromium WITHOUT the `--disable-field-trial-config` | ||
| // | ||
| // Adding the `--disable-field-trial-config` flag or using Chrome canary can change which | ||
| // target the root worker requests are associated with. |
Contributor
Author
There was a problem hiding this comment.
FYI testing with Canary or Stable locally will fail this expectation. I think those versions have the field trial config disabled by default.
connorjclark
approved these changes
Jun 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-core-v22.10.0
https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-core-v22.9.0
https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-core-v22.8.2
https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-core-v22.8.1
https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-core-v22.8.0
https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-core-v22.7.1
https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-core-v22.7.0
Somewhat notable: puppeteer/puppeteer#12377
With the removal of this flag, the results in
api-test-pptr.jsshould matchyarn smoke oopif-scriptsonce again.