tests: reduce expected value of render-blocking-requests smoke#16011
Merged
connorjclark merged 2 commits intomainfrom May 21, 2024
Merged
tests: reduce expected value of render-blocking-requests smoke#16011connorjclark merged 2 commits intomainfrom
connorjclark merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test has started to consistently return values between 90-100 in CI, so lets lower it.
I investigated a bit, and something that sticks out is that
wastedMs(aka download time, according to the comment) being used here did not match the?delayparam at all. This is after simulating the fcp graph, but I'd expect the download times to be longer not shorter. The headers start timing on the trace event contains the delay as expected, so perhaps we are building the lantern graph incorrectly.debug the artifacts yourself - the
http://localhost:10200/dobetterweb/dbw_tester.css?delay=2200is one request that has a wastedMs of much less than its delay:https://github.com/GoogleChrome/lighthouse/actions/runs/9169845726/artifacts/1522909511
node cli "-A=/Users/cjamcl/Downloads/Smokehouse (ubuntu; chrome ToT)/2/dbw" http://localhost:10200/dobetterweb/dbw_tester.html