Merged
Conversation
adamraine
commented
Apr 17, 2024
| score: 0, | ||
| metricSavings: {'FCP': 15}, | ||
| metricSavings: {'FCP': 2000}, | ||
| ...defaultAuditRef, |
Collaborator
There was a problem hiding this comment.
why are these changes so large?
Contributor
Author
There was a problem hiding this comment.
With the new artifacts, 15ms is a negligible change to FCP which results in a 0 for it's overall impact. Using larger numbers ensures that the savings at least register a pulse on our overall impact calculations.
connorjclark
approved these changes
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wouldn't recommend opening any of the artifact/sample JSON diffs :)
This was a simple
yarn update:sample-artifactsfollowed byyarn update:flow-sample-json -aOld report: https://lighthouse-googlechrome.vercel.app/sample-reports/english/
Report on this branch: https://lighthouse-2b4j6cvtp-googlechrome.vercel.app/sample-reports/english/
Old flow report: https://lighthouse-googlechrome.vercel.app/sample-reports/flow-report/
Flow report on this branch: https://lighthouse-2b4j6cvtp-googlechrome.vercel.app/sample-reports/flow-report/