core: remove pre-v10 compat for page graph construction#15948
Merged
connorjclark merged 1 commit intomainfrom Apr 16, 2024
Merged
core: remove pre-v10 compat for page graph construction#15948connorjclark merged 1 commit intomainfrom
connorjclark merged 1 commit intomainfrom
Conversation
adamraine
reviewed
Apr 15, 2024
|
|
||
| // COMPAT: Backport for pre-10.0 clients that don't pass the URL artifact here (e.g. pubads). | ||
| // Calculates the URL artifact from the processed trace and DT log. | ||
| const URL = data.URL || await DocumentUrls.request(data, context); |
Contributor
There was a problem hiding this comment.
This looks like the only usage of DocumentUrls, we can probably just remove it.
Collaborator
Author
There was a problem hiding this comment.
its used in core/scripts/lantern/run-once.js
adamraine
approved these changes
Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.