Merged
Conversation
adamraine
reviewed
Sep 13, 2023
core/config/default-config.js
Outdated
| {id: 'valid-source-maps', weight: 0, group: 'best-practices-general'}, | ||
| {id: 'inspector-issues', weight: 1, group: 'best-practices-general'}, | ||
| {id: 'themed-omnibox', weight: 1, group: 'best-practices-general'}, | ||
| {id: 'viewport', weight: 2, group: 'best-practices-general'}, |
Contributor
There was a problem hiding this comment.
I don't think we need this audit in performance, seo and best practices. I think we should remove it from SEO if we really want it here, but that's a different conversation.
Collaborator
|
found more PWA references:
|
Collaborator
|
connorjclark
approved these changes
Apr 10, 2024
adamraine
reviewed
Apr 10, 2024
| /** The issues surfaced in the devtools Issues panel */ | ||
| InspectorIssues: Artifacts.InspectorIssues; | ||
| /** Errors preventing page being installable as PWA. */ | ||
| InstallabilityErrors: Artifacts.InstallabilityErrors; |
valfirst
added a commit
to vividus-framework/vividus
that referenced
this pull request
May 13, 2024
https://github.com/GoogleChrome/lighthouse/releases/tag/v12.0.0: "As per Chrome’s updated Installability Criteria(https://developer.chrome.com/blog/update-install-criteria), Lighthouse has removed the PWA category (GoogleChrome/lighthouse#15455). For future PWA testing, users will be directed to use the updated PWA documentation: https://developer.chrome.com/docs/devtools/progressive-web-apps/"
valfirst
added a commit
to vividus-framework/vividus
that referenced
this pull request
May 13, 2024
https://github.com/GoogleChrome/lighthouse/releases/tag/v12.0.0: "As per Chrome’s updated Installability Criteria(https://developer.chrome.com/blog/update-install-criteria), Lighthouse has removed the PWA category (GoogleChrome/lighthouse#15455). For future PWA testing, users will be directed to use the updated PWA documentation: https://developer.chrome.com/docs/devtools/progressive-web-apps/"
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated report with PWA category
updated report with no PWA category
checks off the following in issue/5535: