Improve comment in object/commit.rs#2583
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Commit::time()’s documentation to point to the newer Commit::author() API for authored timestamps, avoiding the previously suggested .decode()? detour and making the intended usage clearer and more consistent with the rest of the Commit convenience methods.
Changes:
- Adjust doc comment for
Commit::time()to reference.author()?.time()instead of.decode()?.author()?.time().
Sebastian Thiel (Byron)
approved these changes
May 7, 2026
Sebastian Thiel (Byron)
left a comment
Member
There was a problem hiding this comment.
Thanks, good catch!
a791ea3
into
GitoxideLabs:main
35 of 36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc Sebastian Thiel (@Byron)
Commitnow has anauthormethod as well:Seems we don't need to
decodefirst? Or else the API looks unintuitive to understand.