feat: replace Reference::peel_to_id_in_place_packed#2174
Merged
Byron merged 1 commit intoGitoxideLabs:mainfrom Sep 18, 2025
Merged
feat: replace Reference::peel_to_id_in_place_packed#2174Byron merged 1 commit intoGitoxideLabs:mainfrom
Reference::peel_to_id_in_place_packed#2174Byron merged 1 commit intoGitoxideLabs:mainfrom
Conversation
Also, update documentation where it was still referring to deprecated `in_place` methods to refer to the new methods instead.
Byron
approved these changes
Sep 18, 2025
Member
Byron
left a comment
There was a problem hiding this comment.
This is wonderful, thanks a lot!
I particularly like how it removes … as it's always inconsistent, and how one commit is used to change two crates, while matching well enough for both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is hopefully the last follow-up to #2163 and #2171. It renames the last remaining method that still had an
in_placeinfix,gix::reference::Reference::peel_to_id_in_place_packed, so that now allin_placemethods that deal with references have been deprecated.Note that there are a few other methods that still have an
in_placeinfix or suffix, but are not related to references, such asgix::remote::url::rewrite::Rewrite::rewrite_url_in_place.Also, I updated a couple of doc comments that were still referring to deprecated
in_placemethods to refer to the new methods instead.