Merged
Conversation
Copilot
AI
changed the title
[WIP] Implement the
Implement WriteTo trait for gix::Blob
Sep 14, 2025
WriteTo trait for gix::Blob.Co-authored-by: Byron <63622+Byron@users.noreply.github.com>
221625a to
3499050
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
WriteTotrait forgix::Blob<'repo>, enabling blob objects to be used with APIs that require this trait, such asRepository::write_object().Changes Made
The implementation adds the
WriteTotrait togix::Blob<'repo>ingix/src/object/impls.rswith the following methods:write_to()- writes the blob's data verbatim usingwrite_allkind()- returnsgix_object::Kind::Blobsize()- returns the length of the blob's data asu64This follows the same pattern as the existing
WriteToimplementations forgix_object::Blobandgix_object::BlobRef.Example Usage
Testing
Added comprehensive tests covering:
write_object()WriteTotrait methods (write_to,kind,size)All existing tests continue to pass, ensuring no regressions.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.