review

Byron · Byron · commit 31c2de3d6ea1 · 2026-05-12T12:09:26.000+08:00
diff --git a/gix/src/create.rs b/gix/src/create.rs
@@ -117,8 +117,9 @@ pub struct Options {
     /// If set, use these filesystem capabilities to populate the respective git-config fields.
     /// If `None`, the directory will be probed.
     pub fs_capabilities: Option<gix_fs::Capabilities>,
-    /// If set to `Some(Sha256)`, initialize the repository with SHA-256.
-    /// Otherwise, no object hash will be explicitly set for the repository.
+    /// If set to `Some(Sha256)`, write `extensions.objectFormat=sha256`.
+    /// Otherwise, create a repository without an explicit object-format extension,
+    /// which is interpreted as legacy SHA-1.
     pub object_hash: Option<gix_hash::Kind>,
 }
 
@@ -231,7 +232,6 @@ pub fn into(
                     core.push(key("repositoryformatversion"), Some("1".into()));
 
                     let mut extensions = config.new_section("extensions", None).expect("valid section name");
-
                     extensions.push(
                         key("objectformat"),
                         Some(gix_hash::Kind::Sha256.to_string().as_bytes().into()),
diff --git a/gix/tests/gix/object/tree/mod.rs b/gix/tests/gix/object/tree/mod.rs
@@ -40,16 +40,16 @@ fn decode_uses_the_tree_id_hash_kind() -> crate::Result {
     let mut data = b"100644 file\0".to_vec();
     data.extend_from_slice(bogus_other_hash_entry_id.as_bytes());
 
-    let bogux_other_hash_tree_id = other_hash.empty_tree();
-    let tree = gix::Tree::from_data(bogux_other_hash_tree_id, data, &repo);
+    let bogus_other_hash_tree_id = other_hash.empty_tree();
+    let tree = gix::Tree::from_data(bogus_other_hash_tree_id, data, &repo);
     let decoded = tree.decode()?;
 
     assert_eq!(decoded.entries.len(), 1);
     assert_eq!(decoded.entries[0].filename, b"file".as_bstr());
     assert_eq!(decoded.entries[0].oid, bogus_other_hash_entry_id.as_ref());
     assert_eq!(
         bogus_other_hash_entry_id.kind(),
-        bogux_other_hash_tree_id.kind(),
+        bogus_other_hash_tree_id.kind(),
         "both kinds are expected to match, the `repo.object_hash()` doesn't matter here"
     );
     Ok(())
diff --git a/gix/tests/gix/repository/shallow.rs b/gix/tests/gix/repository/shallow.rs
@@ -136,33 +136,36 @@ mod traverse {
                     .collect::<Vec<_>>()
                 );
 
-                // Generated through `git log --graph --oneline`.
-                //
-                // SHA-1:
-                //
-                // f99771f A
-                // |\
-                // | * 2d9d136 C
-                // | |
-                // |  \
-                // *-. | dfd0954 (tag: b-tag) B
-                // |\ \|
-                // | | * 27e7157 (grafted) F
-                // | * b515286 (grafted) E
-                // * 82024b2 (grafted) D
-                //
-                // SHA-256:
-                //
-                // e36613f A
-                // |\
-                // | * 1e485b4 C
-                // | |
-                // |  \
-                // *-. | 94c0c58 (tag: b-tag) B
-                // |\ \|
-                // | | * c2eec0d (grafted) F
-                // | * a5d87b4 (grafted) E
-                // * 125ce6c (grafted) D
+                if !toggle && name == "shallow" {
+                    let graph = gix_testtools::git(repo.git_dir(), "log --graph --oneline")?;
+                    match gix_testtools::object_hash() {
+                        gix_hash::Kind::Sha1 => insta::assert_snapshot!(graph, @r"
+*   f99771f A
+|\  
+| * 2d9d136 C
+| |   
+|  \  
+*-. | dfd0954 B
+|\ \| 
+| | * 27e7157 F
+| * b515286 E
+* 82024b2 D
+"),
+                        gix_hash::Kind::Sha256 => insta::assert_snapshot!(graph, @r"
+*   e36613f A
+|\  
+| * 1e485b4 C
+| |   
+|  \  
+*-. | 94c0c58 B
+|\ \| 
+| | * c2eec0d F
+| * a5d87b4 E
+* 125ce6c D
+"),
+                        _ => unimplemented!(),
+                    }
+                }
             }
         }
         Ok(())
