review

codex · Byron · Byron · commit 19801900fdce · 2026-05-06T10:37:06.000+08:00
Co-authored-by: Sebastian Thiel &lt;sebastian.thiel@icloud.com&gt;
diff --git a/gix-archive/tests/fixtures/generated-archives/.gitignore b/gix-archive/tests/fixtures/generated-archives/.gitignore
@@ -1,4 +1,4 @@
-# Not tracked: the fixture script uses `ln -s`, an executable-bit toggle, and a
+# The fixture script uses `ln -s`, an executable-bit toggle, and a
 # filter driver — features that cannot be round-tripped through an archive
 # extracted on every supported platform (notably Windows). The script is re-run
 # on the test host instead.
diff --git a/gix-attributes/tests/fixtures/generated-archives/.gitignore b/gix-attributes/tests/fixtures/generated-archives/.gitignore
@@ -1,5 +1,5 @@
-# Not tracked: the fixture bakes a `baseline` file from `git check-attr -a`
-# output produced by the host's `git` binary. The exact format/lookup-order is
-# sensitive to the git version, so the fixture is re-run on the test host to
+# The fixture bakes a `baseline` file from `git check-attr -a`
+# output produced by the host's `git` binary. The exact format/lookup-order may
+# be sensitive to the git version, so the fixture is re-run on the test host to
 # stay aligned with the comparing git.
 make_attributes_baseline.tar
diff --git a/gix-blame/tests/fixtures/generated-archives/.gitignore b/gix-blame/tests/fixtures/generated-archives/.gitignore
@@ -1,6 +1,6 @@
-# Not tracked: the fixture bakes `git blame --porcelain` baseline files (under
+# The fixture bakes `git blame --porcelain` baseline files (under
 # `.git/*.baseline`) produced by the host's `git` binary. The exact textual
-# output is sensitive to the git version, so the fixture is re-run locally to
+# output may be sensitive to the git version, so the fixture is re-run locally to
 # stay aligned with the comparing git on the test host. Both SHA-1 and SHA-256
 # variants share this constraint.
 make_blame_repo.tar
diff --git a/gix-command/tests/fixtures/generated-archives/.gitignore b/gix-command/tests/fixtures/generated-archives/.gitignore
@@ -1,7 +1,7 @@
-# Not tracked: the fixture seeds a tree of files with `.exe`/`.com` names that
+# The fixture seeds a tree of files with `.exe`/`.com` names that
 # carry no content beyond their stub shebang. On Windows, executable extensions
 # are interpreted at runtime and committing such a tree adds little value over
 # regenerating it locally — every test host can produce the same files in a
-# fraction of a second. Re-running the script also keeps the test independent
-# of host-side line-ending or executable-bit conversions on extraction.
+# fraction of a second. Re-running the script also keeps the test aligned with
+# installation-wide Git line-ending and executable-bit behavior on extraction.
 win_path_lookup.tar
diff --git a/gix-config/tests/fixtures/generated-archives/.gitignore b/gix-config/tests/fixtures/generated-archives/.gitignore
@@ -1,4 +1,4 @@
-# Not tracked: the test (`from_git_dir`) drives `gix-config` through
+# The test (`from_git_dir`) drives `gix-config` through
 # `GIT_CONFIG_SYSTEM`, `HOME` and `USERPROFILE` overrides that point at the
 # generated worktree directory. The fixture is regenerated on each host so the
 # `system.config`, `.gitconfig`, `c.config`, `b.config` and XDG-shaped
diff --git a/gix-discover/tests/fixtures/generated-archives/.gitignore b/gix-discover/tests/fixtures/generated-archives/.gitignore
@@ -1,4 +1,4 @@
-# Not tracked: the fixture creates linked worktrees (`git worktree add`) whose
+# The fixture creates linked worktrees (`git worktree add`) whose
 # `.git` files and `.git/worktrees/*/gitdir` entries store absolute paths into
 # the host's working directory. Re-running the script on the test host produces
 # the correct paths for that machine.
diff --git a/gix-filter/tests/fixtures/generated-archives/.gitignore b/gix-filter/tests/fixtures/generated-archives/.gitignore
@@ -1,4 +1,4 @@
-# Not tracked: `baseline.sh` runs the host's `git` through a clean/smudge
+# `baseline.sh` runs the host's `git` through a clean/smudge
 # filter driver supplied as its `$1` argument (a host-absolute path to the test
 # helper binary). Both the driver path and any filter output baked into the
 # resulting working tree are host-specific, so the fixture must be regenerated
diff --git a/gix-fsck/tests/fixtures/generated-archives/.gitignore b/gix-fsck/tests/fixtures/generated-archives/.gitignore
@@ -1,4 +1,4 @@
-# Not tracked: the fixture sets `GIT_CONFIG_GLOBAL` to a host-absolute path and
+# The fixture sets `GIT_CONFIG_GLOBAL` to a host-absolute path and
 # performs `git clone --no-local --no-hardlinks --filter=...` partial clones
 # whose alternates/promisor metadata embeds the host path of `./base`, so a
 # committed archive would not relocate to the test runner's checkout.
diff --git a/gix-ignore/tests/fixtures/generated-archives/.gitignore b/gix-ignore/tests/fixtures/generated-archives/.gitignore
@@ -1,5 +1,5 @@
-# Not tracked: the fixture writes `git-check-ignore.baseline` files captured
+# The fixture writes `git-check-ignore.baseline` files captured
 # from the host's `git check-ignore -vn --stdin` output. The baselines are then
 # diffed against `gix-ignore`, so they must match the comparing git binary on
-# the test host. Regenerating per-run avoids drift across git versions.
+# the test host. Regenerating per-run avoids possible drift across git versions.
 make_global_and_external_and_dir_ignores.tar
diff --git a/gix-index/tests/fixtures/generated-archives/.gitignore b/gix-index/tests/fixtures/generated-archives/.gitignore
@@ -1,4 +1,4 @@
-# Not tracked: `file_metadata.sh` calls `touch -d` with extreme dates (a
+# `file_metadata.sh` calls `touch -d` with extreme dates (a
 # post-2038 future date and a pre-1970 past date) and falls back to a
 # 32-bit-fitting date when the future one is rejected. The actual mtimes that
 # end up on disk depend on the host filesystem's time_t/seconds-resolution
diff --git a/gix-odb/tests/fixtures/generated-archives/.gitignore b/gix-odb/tests/fixtures/generated-archives/.gitignore
@@ -1,11 +1,11 @@
-# Not tracked: the fixtures rely on object-database state that depends on the
-# host (auto-gc/auto-repack thresholds, alternates pointing at absolute paths)
-# and so cannot be reproduced reliably from a committed archive.
+# The fixtures rely on object-database state that cannot be reliably committed:
+# loose-object layout may depend on installation-wide Git auto-gc/repack
+# behavior, and alternates point at host-absolute paths.
 
 # `make_alternates_odb.sh` writes `$PWD/object_source/.git/objects` into
 # `.git/objects/info/alternates`; the absolute path is host-specific.
 make_alternates_odb.tar
 # Fixture deliberately uses loose objects; whether commits remain loose vs. get
-# packed depends on the host git's auto-gc/repack defaults, so the layout is
-# regenerated per run.
+# packed depends on installation-wide Git auto-gc/repack behavior, so the
+# layout is regenerated per run.
 repo_with_loose_objects.tar
diff --git a/gix-ref/tests/fixtures/generated-archives/.gitignore b/gix-ref/tests/fixtures/generated-archives/.gitignore
@@ -1,4 +1,4 @@
-# Not tracked: the fixtures use `git worktree add` and then rewrite the
+# The fixtures use `git worktree add` and then rewrite the
 # linked-worktree `.git` files (`gitdir:` pointer) and `.git/worktrees/*/gitdir`
 # entries. Those paths are absolute or relative to the host's working
 # directory, so the layout cannot relocate cleanly when extracted from a
@@ -7,7 +7,7 @@
 make_worktree_repo.tar
 make_worktree_repo_sha256.tar
 # `_packed` variants additionally run `git pack-refs --all --prune`, whose
-# pack-refs file format may vary slightly across git versions.
+# pack-refs file format can vary slightly across git versions.
 make_worktree_repo_packed.tar
 make_worktree_repo_packed_sha256.tar
 # `make_multi_hop_ref.sh` writes raw symbolic-ref text files under `.git/refs`
diff --git a/gix-refspec/tests/fixtures/generated-archives/.gitignore b/gix-refspec/tests/fixtures/generated-archives/.gitignore
@@ -1,6 +1,6 @@
-# Not tracked: the fixture captures `baseline.git` files from
+# The fixture captures `baseline.git` files from
 # `git fetch --refmap= --dry-run -v origin <spec>` output. That textual format
-# changes between git versions, so the baseline must be produced by the host's
+# may change between git versions, so the baseline must be produced by the host's
 # `git` to keep the comparison meaningful. Both SHA-1 and SHA-256 variants
 # share this constraint.
 /match_baseline.tar
diff --git a/gix-status/tests/fixtures/generated-archives/.gitignore b/gix-status/tests/fixtures/generated-archives/.gitignore
@@ -11,7 +11,8 @@ status_changed.tar
 symlink_stack.tar
 # Uses `mkfifo`; FIFOs cannot be represented in archives extracted on Windows.
 status_nonfile.tar
-# Uses `ln -sf` plus `core.autocrlf` line-ending normalization on checkout.
+# Uses `ln -sf` plus installation-wide `core.autocrlf` line-ending normalization
+# on checkout.
 status_unchanged_filter.tar
 # Uses `chmod 000` on a tracked file; the unreadable mode is not portable.
 unreadable_untracked.tar
diff --git a/gix-url/tests/fixtures/generated-archives/.gitignore b/gix-url/tests/fixtures/generated-archives/.gitignore
@@ -1,5 +1,5 @@
-# Not tracked: the fixture captures `git-baseline.unix` and `git-baseline.windows`
+# The fixture captures `git-baseline.unix` and `git-baseline.windows`
 # files by piping a large set of URLs through `git fetch-pack --diag-url`. That
-# textual output is sensitive to the git version, so the baseline must be
+# textual output may be sensitive to the git version, so the baseline must be
 # produced by the host's `git` to keep the comparison meaningful.
 make_baseline.tar
diff --git a/gix-worktree-state/tests/fixtures/generated-archives/.gitignore b/gix-worktree-state/tests/fixtures/generated-archives/.gitignore
@@ -4,7 +4,7 @@
 # committed tar across all supported platforms.
 
 # Shares its script with `gix-worktree`; bakes `git check-ignore` baseline
-# output that depends on the host git version.
+# output that may depend on the host git version.
 make_ignore_and_attributes_setup.tar
 # Uses `ln -sf` to create a symlink in the working tree.
 make_mixed_without_submodules.tar
@@ -15,7 +15,7 @@ make_mixed.tar
 # the working tree depends on the test driver being available at run time;
 # generating once per host avoids drift.
 make_mixed_without_submodules_and_symlinks.tar
-# Bakes `git check-attr` baseline output, which varies by git version.
+# Bakes `git check-attr` baseline output, which may vary by git version.
 make_attributes_baseline.tar
 # Constructs intentionally malicious symlinks (e.g., `FAKE-DIR`, `FAKE-FILE`);
 # these cannot be safely unpacked on every platform.
diff --git a/gix-worktree-stream/tests/fixtures/generated-archives/.gitignore b/gix-worktree-stream/tests/fixtures/generated-archives/.gitignore
@@ -1,4 +1,4 @@
-# Not tracked: the fixture creates symlinks (`ln -s`) and registers a
+# The fixture creates symlinks (`ln -s`) and registers a
 # `filter=arrow` filter driver. Symlinks cannot be unpacked on Windows without
 # elevated privileges, so the script is re-run on the test host instead.
 basic.tar
diff --git a/gix-worktree/tests/fixtures/generated-archives/.gitignore b/gix-worktree/tests/fixtures/generated-archives/.gitignore
@@ -3,9 +3,10 @@
 # round-tripped through a committed tar across all supported platforms.
 
 # Bakes `git check-ignore -vn` baseline output and uses `core.excludesFile`
-# pointing at a file outside the repo; both vary by git version and host path.
+# pointing at a file outside the repo; both may vary by git version and host
+# path.
 make_ignore_and_attributes_setup.tar
-# Bakes `git check-attr` baseline output, which varies by git version.
+# Bakes `git check-attr` baseline output, which may vary by git version.
 make_attributes_baseline.tar
 # Uses `ln -s` (including a symlink to the base directory); symlinks do not
 # unpack on Windows without elevated privileges.
diff --git a/gix/tests/fixtures/generated-archives/.gitignore b/gix/tests/fixtures/generated-archives/.gitignore
@@ -9,7 +9,7 @@
 # and the worktree's `.git` pointer file; both shared with the `_bare` variant.
 /make_worktree_repo.tar
 /make_worktree_repo_bare.tar
-# Same as above, plus per-worktree `extensions.worktreeConfig` settings.
+# Same as above, plus per-worktree config created via `extensions.worktreeConfig`.
 /make_worktree_repo_with_configs.tar
 # `git clone --shared file://$PWD/base` records the host-absolute alternates
 # path; numerous sub-clones inherit that reference.

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		-# Not tracked: the fixture script uses `ln -s`, an executable-bit toggle, and a
	`1`	+# The fixture script uses `ln -s`, an executable-bit toggle, and a
`2`	`2`	`# filter driver — features that cannot be round-tripped through an archive`
`3`	`3`	`# extracted on every supported platform (notably Windows). The script is re-run`
`4`	`4`	`# on the test host instead.`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		-# Not tracked: the test (`from_git_dir`) drives `gix-config` through
	`1`	+# The test (`from_git_dir`) drives `gix-config` through
`2`	`2`	# `GIT_CONFIG_SYSTEM`, `HOME` and `USERPROFILE` overrides that point at the
`3`	`3`	`# generated worktree directory. The fixture is regenerated on each host so the`
`4`	`4`	# `system.config`, `.gitconfig`, `c.config`, `b.config` and XDG-shaped
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		-# Not tracked: the fixture creates linked worktrees (`git worktree add`) whose
	`1`	+# The fixture creates linked worktrees (`git worktree add`) whose
`2`	`2`	# `.git` files and `.git/worktrees/*/gitdir` entries store absolute paths into
`3`	`3`	`# the host's working directory. Re-running the script on the test host produces`
`4`	`4`	`# the correct paths for that machine.`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		-# Not tracked: `baseline.sh` runs the host's `git` through a clean/smudge
	`1`	+# `baseline.sh` runs the host's `git` through a clean/smudge
`2`	`2`	# filter driver supplied as its `$1` argument (a host-absolute path to the test
`3`	`3`	`# helper binary). Both the driver path and any filter output baked into the`
`4`	`4`	`# resulting working tree are host-specific, so the fixture must be regenerated`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		-# Not tracked: the fixture sets `GIT_CONFIG_GLOBAL` to a host-absolute path and
	`1`	+# The fixture sets `GIT_CONFIG_GLOBAL` to a host-absolute path and
`2`	`2`	# performs `git clone --no-local --no-hardlinks --filter=...` partial clones
`3`	`3`	# whose alternates/promisor metadata embeds the host path of `./base`, so a
`4`	`4`	`# committed archive would not relocate to the test runner's checkout.`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		-# Not tracked: `file_metadata.sh` calls `touch -d` with extreme dates (a
	`1`	+# `file_metadata.sh` calls `touch -d` with extreme dates (a
`2`	`2`	`# post-2038 future date and a pre-1970 past date) and falls back to a`
`3`	`3`	`# 32-bit-fitting date when the future one is rejected. The actual mtimes that`
`4`	`4`	`# end up on disk depend on the host filesystem's time_t/seconds-resolution`