Skip to content

Conversation

@kanat
Copy link
Contributor

@kanat kanat commented Feb 6, 2024

🎯 Goal

Resolves:

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat linked an issue Feb 6, 2024 that may be closed by this pull request
@kanat kanat marked this pull request as ready for review February 6, 2024 19:15
@kanat kanat requested a review from a team as a code owner February 6, 2024 19:15
@JcMinarro JcMinarro merged commit 60f6665 into develop Feb 6, 2024
@JcMinarro JcMinarro deleted the bugfix/cancel-giphy branch February 6, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cancel giphy in a channel, leave channel and come back, it still shows.

3 participants