Skip to content

[i208] fix channel title position when typing #5073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JcMinarro merged 2 commits into from
Nov 20, 2023
Merged

[i208] fix channel title position when typing #5073

JcMinarro merged 2 commits into from
Nov 20, 2023

Conversation

@kanat
Copy link
Contributor

@kanat kanat commented Nov 19, 2023

🎯 Goal

Related ticket: https://github.com/GetStream/android-internal-board/issues/208
Related PR: #5043

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat marked this pull request as ready for review November 19, 2023 14:32
@kanat kanat requested a review from a team as a code owner November 19, 2023 14:32
@kanat kanat changed the title [i208] fix channel title position for typing [i208] fix channel title position when typing Nov 19, 2023
@kanat kanat added the bug Something isn't working label Nov 19, 2023
@JcMinarro JcMinarro enabled auto-merge (rebase) November 20, 2023 09:47
kanat and others added 2 commits November 20, 2023 10:51
@kanat @JcMinarro
[i208] fix channel title position for typing
2c49f0e 
(cherry picked from commit 01dc099)

# Conflicts:
#	stream-chat-android-ui-components/detekt-baseline.xml
#	stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/feature/channels/list/adapter/viewholder/internal/ChannelViewHolder.kt
@JcMinarro
Update CHANGELOG.md
da5a42c
@JcMinarro JcMinarro force-pushed the fix/channel-title-v6 branch from 25f672b to da5a42c Compare November 20, 2023 09:51
@JcMinarro JcMinarro merged commit dba3e0d into develop Nov 20, 2023
@JcMinarro JcMinarro deleted the fix/channel-title-v6 branch November 20, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JcMinarro JcMinarro JcMinarro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working ui-components v6

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kanat @JcMinarro