Skip to content

[i212] allow composer icons customizations #5064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JcMinarro merged 2 commits into from
Nov 14, 2023
Merged

[i212] allow composer icons customizations #5064

JcMinarro merged 2 commits into from
Nov 14, 2023

Conversation

@kanat
Copy link
Contributor

@kanat kanat commented Nov 13, 2023

🎯 Goal

Closes: https://github.com/GetStream/android-internal-board/issues/212

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat marked this pull request as ready for review November 13, 2023 20:12
@kanat kanat requested a review from a team as a code owner November 13, 2023 20:12
@kanat kanat added enhancement New feature or request ui-components v6 labels Nov 13, 2023
@JcMinarro JcMinarro merged commit 07fd42c into develop Nov 14, 2023
@JcMinarro JcMinarro deleted the enhancement/composer-style-customizations-v6 branch November 14, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JcMinarro JcMinarro JcMinarro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request ui-components v6

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kanat @JcMinarro