Skip to content

[i68] Add hide_history flag support while adding members #4817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JcMinarro merged 4 commits into from
May 16, 2023
Merged

[i68] Add hide_history flag support while adding members #4817

JcMinarro merged 4 commits into from
May 16, 2023

Conversation

@kanat
Copy link
Contributor

@kanat kanat commented May 15, 2023

🎯 Goal

Closes: https://github.com/GetStream/android-internal-board/issues/68

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat requested a review from a team as a code owner May 15, 2023 22:13
@kanat kanat self-assigned this May 15, 2023
@kanat kanat changed the title [i68] - Add hide_history flag support while adding members [i68] Add hide_history flag support while adding members May 15, 2023
@kanat kanat added the v5 label May 16, 2023
@kanat kanat removed their assignment May 16, 2023
@kanat kanat requested a review from JcMinarro May 16, 2023 04:07
@JcMinarro JcMinarro enabled auto-merge (rebase) May 16, 2023 08:36
@JcMinarro JcMinarro merged commit eebb029 into v5 May 16, 2023
@JcMinarro JcMinarro deleted the feature/internal-68 branch May 16, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JcMinarro JcMinarro JcMinarro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

v5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kanat @JcMinarro