Thread messages start feature #4806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4daf5d7 to
c037254
Compare
kanat
approved these changes
May 9, 2023
Contributor
kanat
left a comment
There was a problem hiding this comment.
LGTM.
Are we gonna support this in XML as well?
Contributor
Author
It was already implemented on XML: https://getstream.io/chat/docs/sdk/android/ui/message-components/message-list/#messages-start-position |
|
After updating the SDK to the latest version, suddenly the messages in channels (not threads) are always aligned at the top. You see on this line if there is no parent message, alignment is Top, but it used to be Bottom before this change. Should I make a new bug ticket for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Be able to set position where the thread messages will start from.
Complete GetStream/android-internal-board#62
🎨 UI Changes
Add relevant screenshots
🎉 GIF