-
Notifications
You must be signed in to change notification settings - Fork 309
Fix image scaling #4659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix image scaling #4659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinTolic
suggested changes
Feb 8, 2023
Contributor
MarinTolic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested in the comments.
...io/getstream/chat/android/ui/message/list/adapter/view/internal/ImageAttachmentsGroupView.kt
Show resolved
Hide resolved
...io/getstream/chat/android/ui/message/list/adapter/view/internal/ImageAttachmentsGroupView.kt
Outdated
Show resolved
Hide resolved
4f00de0 to
f82d345
Compare
MarinTolic
approved these changes
Feb 9, 2023
Contributor
MarinTolic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☑️Reviewer Checklist
- UI Components sample runs & works
- Compose sample runs & works
- UI Changes correct (before & after images)
- Bugs validated (bugfixes)
- New feature tested and works
- Release notes and docs clearly describe changes
- All code we touched has new or updated KDocs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
sdk-issue
Used for issues/bugs opened/reported by customers or us.
ui-components
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Closes #4657
🛠 Implementation details
Apply
fitXYscaling if the image height on the screen is smaller than the max container height. OtherwisecenterCropso scaling is not broken.🎨 UI Changes
🧪 Testing
☑️Contributor Checklist
General
developbranchCode & documentation
☑️Reviewer Checklist
🎉 GIF