Add createConnection option for http or https requests#120
Merged
rexxars merged 1 commit intoEventSource:masterfrom Jan 25, 2020
Merged
Add createConnection option for http or https requests#120rexxars merged 1 commit intoEventSource:masterfrom
createConnection option for http or https requests#120rexxars merged 1 commit intoEventSource:masterfrom
Conversation
|
@aslakhellesoy any chance we can get this merged? |
Member
|
Thanks for contributing! |
Contributor
|
The supplied test won’t fail if The feature is undocumented. This didn’t seem quite ready to be merged. Sorry for my late review! |
Member
|
It's checked on line 611, in the request handler - I'll add documentation for the feature unless you want this reverted. |
Contributor
|
You're right @rexxars - that will teach me to stop doing code reviews on my phone :-) |
This was referenced Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #119