Update arguments parsing from expressions #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10bdaaa to
3f55951
Compare
Contributor
|
@codingricky Could you please review this PR? this fix is crucial for us |
3f55951 to
c8b463b
Compare
c8b463b to
8fe21b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a trouble to execute expressions with more than 2 args like this
#{Number.randomDouble '2','1','1000'}
Pattern
#\{([a-z0-9A-Z_.]+)\s?(?:'([^']+)')?(?:,'([^']+)')}
determinants just the last one match for group (?:,'([^']+)'), as a result middle args are missed and wrong directive is built