Skip to content

Support non-ascii GraphQL headers#3041

Merged
jonathanmos merged 2 commits into
developfrom
jmoskovich/hotfix-graphql
Dec 10, 2025
Merged

Support non-ascii GraphQL headers#3041
jonathanmos merged 2 commits into
developfrom
jmoskovich/hotfix-graphql

Conversation

@jonathanmos

@jonathanmos jonathanmos commented Dec 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Support GraphQL headers that are non-ascii by encoding payloads to base64 in the DatadogApolloInterceptor and decoding them in the DatadogInterceptor.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@jonathanmos jonathanmos force-pushed the jmoskovich/hotfix-graphql branch from c1cde01 to 1f03bde Compare December 8, 2025 15:37
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Dec 8, 2025 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown

🎯 Code Coverage
• Patch Coverage: 93.75%
• Total Coverage: 71.38% (+0.03%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a29addc | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter

codecov-commenter commented Dec 9, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.12%. Comparing base (d2a2ec9) to head (a29addc).
⚠️ Report is 1018 commits behind head on develop.

Files with missing lines Patch % Lines
...n/com/datadog/android/okhttp/DatadogInterceptor.kt 66.67% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3041      +/-   ##
===========================================
- Coverage    71.23%   71.12%   -0.11%     
===========================================
  Files          864      864              
  Lines        31604    31612       +8     
  Branches      5324     5327       +3     
===========================================
- Hits         22510    22482      -28     
- Misses        7582     7606      +24     
- Partials      1512     1524      +12
Files with missing lines Coverage Δ
...datadog/android/apollo/DatadogApolloInterceptor.kt 93.55% <100.00%> (+0.22%) ⬆️
...n/com/datadog/android/okhttp/DatadogInterceptor.kt 73.08% <66.67%> (-0.93%) ⬇️

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonathanmos jonathanmos force-pushed the jmoskovich/hotfix-graphql branch from 1f03bde to 48cb364 Compare December 9, 2025 09:42
@jonathanmos jonathanmos marked this pull request as ready for review December 9, 2025 10:42
@jonathanmos jonathanmos requested a review from a team as a code owner December 9, 2025 10:42
ambushwork
ambushwork previously approved these changes Dec 9, 2025
View reviewed changes
@ambushwork

ambushwork commented Dec 10, 2025

Copy link
Copy Markdown
Member

Well done!

ambushwork
ambushwork previously approved these changes Dec 10, 2025
View reviewed changes
0xnm
0xnm previously approved these changes Dec 10, 2025
View reviewed changes
Comment thread ...-sdk-android-apollo/src/test/java/com/datadog/android/apollo/DatadogApolloInterceptorTest.kt Outdated
@jonathanmos jonathanmos dismissed stale reviews from 0xnm and ambushwork via a29addc December 10, 2025 10:28
@jonathanmos jonathanmos force-pushed the jmoskovich/hotfix-graphql branch from b924e5f to a29addc Compare December 10, 2025 10:28
@jonathanmos jonathanmos merged commit 0a32838 into develop Dec 10, 2025
26 of 27 checks passed
@jonathanmos jonathanmos deleted the jmoskovich/hotfix-graphql branch December 10, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
@ambushwork ambushwork ambushwork approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonathanmos @codecov-commenter @ambushwork @0xnm