Skip to content

RUM-9726: Support content scaling in compose#3035

Merged
jonathanmos merged 2 commits into
developfrom
jmoskovich/rum-9726/compose-content-scaling
Dec 10, 2025
Merged

RUM-9726: Support content scaling in compose#3035
jonathanmos merged 2 commits into
developfrom
jmoskovich/rum-9726/compose-content-scaling

Conversation

@jonathanmos

@jonathanmos jonathanmos commented Dec 2, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Adds support in the replays for all the various scale types in compose (crop, fit, fillHeight, fillWidth, inside, fillBounds).

Motivation

Improve compose session quality.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Dec 2, 2025 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 71.47% (+0.11%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0b8255f | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter

codecov-commenter commented Dec 2, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.09859% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.24%. Comparing base (d2a2ec9) to head (0b8255f).

Files with missing lines Patch % Lines
...rnal/mappers/semantics/ImageSemanticsNodeMapper.kt 89.74% 3 Missing and 9 partials ⚠️
...onreplay/compose/internal/utils/ReflectionUtils.kt 0.00% 8 Missing ⚠️
...y/compose/internal/reflection/ComposeReflection.kt 0.00% 2 Missing ⚠️
...ionreplay/compose/internal/utils/SemanticsUtils.kt 83.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3035      +/-   ##
===========================================
+ Coverage    71.23%   71.24%   +0.01%     
===========================================
  Files          864      864              
  Lines        31604    31733     +129     
  Branches      5324     5357      +33     
===========================================
+ Hits         22510    22606      +96     
- Misses        7582     7587       +5     
- Partials      1512     1540      +28
Files with missing lines Coverage Δ
.../sessionreplay/compose/internal/data/BitmapInfo.kt 100.00% <100.00%> (ø)
...y/compose/internal/reflection/ComposeReflection.kt 0.00% <0.00%> (ø)
...ionreplay/compose/internal/utils/SemanticsUtils.kt 69.73% <83.33%> (-3.18%) ⬇️
...onreplay/compose/internal/utils/ReflectionUtils.kt 1.22% <0.00%> (-0.13%) ⬇️
...rnal/mappers/semantics/ImageSemanticsNodeMapper.kt 90.98% <89.74%> (+82.98%) ⬆️

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonathanmos jonathanmos force-pushed the jmoskovich/rum-9726/compose-content-scaling branch from 4c3b25e to 8bcc75d Compare December 8, 2025 09:11
@jonathanmos jonathanmos force-pushed the jmoskovich/rum-9726/compose-content-scaling branch from 8bcc75d to 27cf175 Compare December 8, 2025 13:13
@jonathanmos jonathanmos marked this pull request as ready for review December 9, 2025 09:58
@jonathanmos jonathanmos requested a review from a team as a code owner December 9, 2025 09:58
@ambushwork

ambushwork commented Dec 9, 2025

Copy link
Copy Markdown
Member

LGTM, is there any plan to add instrumented test for this?

@jonathanmos jonathanmos merged commit 3496bba into develop Dec 10, 2025
26 checks passed
@jonathanmos jonathanmos deleted the jmoskovich/rum-9726/compose-content-scaling branch December 10, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
@ambushwork ambushwork ambushwork approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonathanmos @codecov-commenter @ambushwork @0xnm