Skip to content

Add anonymousId to the empty UserInfo object check#3012

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/improve-empty-userinfo-object-check-with-anonymousid
Nov 19, 2025
Merged

Add anonymousId to the empty UserInfo object check#3012
0xnm merged 1 commit into
developfrom
nogorodnikov/improve-empty-userinfo-object-check-with-anonymousid

Conversation

@0xnm

@0xnm 0xnm commented Nov 18, 2025

Copy link
Copy Markdown
Member

What does this PR do?

We were missing anonymousId property in the UserInfo object check for data, this could lead to anonymousId not being sent if there is not other user data set.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners November 18, 2025 13:57
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.17%. Comparing base (499916c) to head (aa4fdd9).

Files with missing lines Patch % Lines
...g/android/rum/internal/DatadogLateCrashReporter.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3012      +/-   ##
===========================================
- Coverage    71.21%   71.17%   -0.04%     
===========================================
  Files          859      859              
  Lines        31336    31336              
  Branches      5279     5279              
===========================================
- Hits         22314    22301      -13     
- Misses        7524     7537      +13     
  Partials      1498     1498              
Files with missing lines Coverage Δ
...datadog/android/rum/internal/utils/RuntimeUtils.kt 50.00% <100.00%> (ø)
...g/android/rum/internal/DatadogLateCrashReporter.kt 85.34% <0.00%> (-1.57%) ⬇️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm 0xnm merged commit 88d29ba into develop Nov 19, 2025
27 of 30 checks passed
@0xnm 0xnm deleted the nogorodnikov/improve-empty-userinfo-object-check-with-anonymousid branch November 19, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants