RUM-12891: Fix RUM resource duration breakdown#3010
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3010 +/- ##
===========================================
+ Coverage 71.08% 71.33% +0.25%
===========================================
Files 859 859
Lines 31315 31320 +5
Branches 5276 5276
===========================================
+ Hits 22260 22341 +81
+ Misses 7552 7506 -46
+ Partials 1503 1473 -30
🚀 New features to boost your workflow:
|
0xnm
approved these changes
Dec 3, 2025
satween
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PRs fixes the resource duration breakdown feature which is broken since the version 2.12.0, more precisely from this commit.
The main cause of issue:
We have
DatadogInteceptorgenerating the RUM eventstartResourcewith theResourceId(requestUrl, randomUUID)as the key of the resource when intercepting a request, also we haveDatadogEventListenerto addwaitForResourceTimingevent andaddResourceTimingto report the resource timing for this duration breakdown.The issue is that, both
DatadogInteceptorandDatadogEventListenerare generating their own UUID for the same request, so in our event processing they won’t be able to match.The fix is to remove the generation of UUID in
DatadogEventListenersince its key is only used for enhancing the current resource.Motivation
RUM-12891
Demo
Review checklist (to be filled by reviewers)