Skip to content

RUM-12810: Add versionCode and buildId in more places#3007

Merged
aleksandr-gringauz merged 5 commits into
developfrom
aleksandr-gringauz/RUM-12810/add-versioncode-as-buildversion
Nov 19, 2025
Merged

RUM-12810: Add versionCode and buildId in more places#3007
aleksandr-gringauz merged 5 commits into
developfrom
aleksandr-gringauz/RUM-12810/add-versioncode-as-buildversion

Conversation

@aleksandr-gringauz

@aleksandr-gringauz aleksandr-gringauz commented Nov 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

  1. Sending versionCode in build_version field of RUM and Logs events.
  2. Sending build_id in RUM events that are not errors (actions, resources, etc). Similar to how it is done on iOS. Currently I don't know if build_id in an ActionEvent for example is used, but I suppose sending it will not hurt, especially if it is in the schema.

See the linked Jira ticket for more info.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@aleksandr-gringauz aleksandr-gringauz force-pushed the aleksandr-gringauz/RUM-12810/add-versioncode-as-buildversion branch 3 times, most recently from aa5c44b to 7ed089a Compare November 17, 2025 17:11
@aleksandr-gringauz aleksandr-gringauz force-pushed the aleksandr-gringauz/RUM-12810/add-versioncode-as-buildversion branch from 7ed089a to 083a27c Compare November 18, 2025 08:34
@datadog-datadog-prod-us1

This comment has been minimized.

Sign in to view
@codecov-commenter

codecov-commenter commented Nov 18, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.16%. Comparing base (499916c) to head (2983257).
⚠️ Report is 1063 commits behind head on develop.

Files with missing lines Patch % Lines
...tadog/android/core/internal/NoOpContextProvider.kt 0.00% 1 Missing ⚠️
...oid/core/internal/system/NoOpAppVersionProvider.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3007      +/-   ##
===========================================
- Coverage    71.21%   71.16%   -0.05%     
===========================================
  Files          859      859              
  Lines        31336    31358      +22     
  Branches      5279     5281       +2     
===========================================
+ Hits         22314    22315       +1     
- Misses        7524     7554      +30     
+ Partials      1498     1489       -9
Files with missing lines Coverage Δ
.../com/datadog/android/api/context/DatadogContext.kt 100.00% <100.00%> (ø)
...n/com/datadog/android/core/internal/CoreFeature.kt 85.34% <100.00%> (+0.37%) ⬆️
...og/android/core/internal/DatadogContextProvider.kt 98.15% <100.00%> (+0.03%) ⬆️
.../core/internal/system/DefaultAppVersionProvider.kt 100.00% <100.00%> (ø)
...android/log/internal/domain/DatadogLogGenerator.kt 97.99% <100.00%> (+0.01%) ⬆️
...ndroid/rum/internal/domain/scope/RumActionScope.kt 97.03% <100.00%> (+0.53%) ⬆️
...roid/rum/internal/domain/scope/RumResourceScope.kt 91.25% <100.00%> (+0.96%) ⬆️
.../android/rum/internal/domain/scope/RumViewScope.kt 94.23% <100.00%> (+0.25%) ⬆️
...tadog/android/core/internal/NoOpContextProvider.kt 2.22% <0.00%> (-0.05%) ⬇️
...oid/core/internal/system/NoOpAppVersionProvider.kt 50.00% <0.00%> (-16.67%) ⬇️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aleksandr-gringauz aleksandr-gringauz changed the title RUM-12810: Add versionCode as build_version to RUM events and logs RUM-12810: Add versionCode and buildId in more places Nov 18, 2025
@aleksandr-gringauz aleksandr-gringauz marked this pull request as ready for review November 18, 2025 09:46
@aleksandr-gringauz aleksandr-gringauz requested review from a team as code owners November 18, 2025 09:46
@aleksandr-gringauz aleksandr-gringauz force-pushed the aleksandr-gringauz/RUM-12810/add-versioncode-as-buildversion branch from d47fbcf to 236c36d Compare November 18, 2025 11:24
0xnm
0xnm previously approved these changes Nov 18, 2025
View reviewed changes
Comment thread ...ndroid-core/src/test/kotlin/com/datadog/android/utils/config/CoreFeatureTestConfiguration.kt Outdated
Comment thread ...ndroid-logs/src/test/kotlin/com/datadog/android/log/internal/logger/DatadogLogHandlerTest.kt Outdated
@aleksandr-gringauz aleksandr-gringauz force-pushed the aleksandr-gringauz/RUM-12810/add-versioncode-as-buildversion branch from 236c36d to 99b7d2f Compare November 18, 2025 12:40
@aleksandr-gringauz aleksandr-gringauz merged commit fce2b76 into develop Nov 19, 2025
26 of 31 checks passed
@aleksandr-gringauz aleksandr-gringauz deleted the aleksandr-gringauz/RUM-12810/add-versioncode-as-buildversion branch November 19, 2025 08:47
@jonathanmos jonathanmos mentioned this pull request Nov 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aleksandr-gringauz @codecov-commenter @0xnm