Skip to content

RUM-12069: Add service name to ddtags of LogEvent#3006

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-12069/copy-service-to-ddtags-in-logs
Nov 18, 2025
Merged

RUM-12069: Add service name to ddtags of LogEvent#3006
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-12069/copy-service-to-ddtags-in-logs

Conversation

@0xnm

@0xnm 0xnm commented Nov 14, 2025

Copy link
Copy Markdown
Member

What does this PR do?

This PR adds service name to the ddtags property of LogEvent to align with what Browser SDK is doing.

iOS SDK counterpart is here DataDog/dd-sdk-ios#2575.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm force-pushed the nogorodnikov/rum-12069/copy-service-to-ddtags-in-logs branch from eb69209 to 0687e2d Compare November 14, 2025 15:53
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Nov 14, 2025 •
edited
Loading

Copy link
Copy Markdown

🎯 Code Coverage
• Patch Coverage: 93.33%
• Total Coverage: 71.24% (-0.02%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0687e2d | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter

codecov-commenter commented Nov 14, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.15%. Comparing base (2a08737) to head (0687e2d).

Files with missing lines Patch % Lines
...id/webview/internal/log/WebViewLogEventConsumer.kt 82.61% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3006      +/-   ##
===========================================
+ Coverage    71.14%   71.15%   +0.01%     
===========================================
  Files          859      859              
  Lines        31315    31336      +21     
  Branches      5276     5279       +3     
===========================================
+ Hits         22278    22295      +17     
+ Misses        7548     7542       -6     
- Partials      1489     1499      +10
Files with missing lines Coverage Δ
...android/log/internal/domain/DatadogLogGenerator.kt 97.98% <100.00%> (+0.06%) ⬆️
...id/webview/internal/log/WebViewLogEventConsumer.kt 81.32% <82.61%> (-0.26%) ⬇️

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm 0xnm marked this pull request as ready for review November 14, 2025 16:33
@0xnm 0xnm requested review from a team as code owners November 14, 2025 16:33
@0xnm 0xnm merged commit 494081b into develop Nov 18, 2025
26 checks passed
@0xnm 0xnm deleted the nogorodnikov/rum-12069/copy-service-to-ddtags-in-logs branch November 18, 2025 08:03
@0xnm 0xnm mentioned this pull request Dec 12, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambushwork ambushwork ambushwork approved these changes
@jonathanmos jonathanmos jonathanmos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@0xnm @codecov-commenter @ambushwork @jonathanmos