RUM-10805: Remove resolveMeta & resolveMetrics methods in tests#3005
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: d312ed9 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3005 +/- ##
===========================================
+ Coverage 71.17% 71.33% +0.17%
===========================================
Files 859 859
Lines 31429 31434 +5
Branches 5298 5298
===========================================
+ Hits 22367 22423 +56
+ Misses 7555 7525 -30
+ Partials 1507 1486 -21
🚀 New features to boost your workflow:
|
| .hasField(TRACER_KEY) { | ||
| hasField(TRACER_VERSION_KEY, context.sdkVersion) | ||
| } | ||
| .hasField(USR_KEY) {} |
There was a problem hiding this comment.
I believe there should be something here?
There was a problem hiding this comment.
All the fields of SpanEvent.Usr are nullable and they are not used or set for these tests.
There was a problem hiding this comment.
Then this is something we shouldn't have. We should either set User object for the test or not add empty UserInfo object (like we do in RUM) to the trace event (or both), because sending object with empty property doesn't really make any sense.
Also I see that UserInfo.anonymousId is not set for the Span event, it is worth checking if it is on purpose or it is a miss.
What does this PR do?
Motivation
resolveMetaandresolveMetricsmethods used production code to generate expected values, then compared those values against the actual output.Review checklist (to be filled by reviewers)