Conversation
Contributor
|
did we compare the resulted cold start time? asking because i wonder if the env is read "early" enough ignore above. just saw the comparison in slack channel. |
Contributor
Author
|
Yeah I had to move it from tracing.py to here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This was enabled by default in dd-trace-py, but doesn't apply to lambda and is responsible for about a 128ms cold start increase.
This will disable it unless the user explicitly opts-in.
Motivation
I want this to go fast.
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply