GitLab Code Quality output#786
Merged
chrismair merged 5 commits intoOct 7, 2024
Merged
Conversation
27593dd to
eb5db29
Compare
Contributor
|
Thanks. I'll take a look. |
eb5db29 to
fe1561a
Compare
Contributor
|
Looks good so far. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the feature I already announced in #785.
Demonstrating that it works is a bit difficult, because it requires a complete context switch from GitHub here to GitLab. I've set up an example project on GitLab, actually a CodeNarc fork, in order to test this implementation, but I'm not sure whether this is really good to demo it to others. Please ask if there are things that are unclear.
The UI there displays this currently:
. The comparison ("6 new findings") is with a dummy report. Normally, that is compared with the report from the branch which you're trying to merge into, but that needs this report writer. To work around this chicken-and-egg problem, I just used a dummy report.
BTW: The first commit is just refactoring, adding a few type annotations, and technically independent of this PR, but it made the new feature easier to develop for me.
Greetings from Hamburg!
Uli