Skip to content

Add wandb logging support to Trainer class#166

Merged
janosh merged 6 commits intomainfrom
wandb
Jun 13, 2024
Merged

Add wandb logging support to Trainer class#166
janosh merged 6 commits intomainfrom
wandb

Conversation

@janosh
Copy link
Copy Markdown
Collaborator

@janosh janosh commented Jun 12, 2024 •
edited
Loading

@BowenD-UCB let me know if you'd like to review this

here's the run metadata that's recorded by default

Screenshot 2024-06-12 at 18 55 50

@janosh janosh added enhancement New feature or request ux User experience training Questions and issues about training the model labels Jun 12, 2024
@bowen-bd
Copy link
Copy Markdown
Collaborator

bowen-bd commented Jun 13, 2024

Thanks for the implementation!
I can take a look into the wandb logger later, I assume it's already working well on your side?
Is it possible to add some test to this?

@janosh
Copy link
Copy Markdown
Collaborator Author

janosh commented Jun 13, 2024 •
edited
Loading

I can take a look into the wandb logger later, I assume it's already working well on your side?

yes

Is it possible to add some test to this?

i did in e7ef618. happy to add more if we can think of good tests.

EDIT: extended the test coverage to extra_run_config in bc87fd0

janosh added 2 commits June 13, 2024 12:41
@janosh
add and test extra_run_config: dict | None = None keyword to Trainer …
bc87fd0 
…to specify run params like batch_size that aren't already recorded by the trainer_args dict
@janosh
fix ruff isort.known-third-party = ["wandb"]
508abef
@janosh janosh merged commit 9717a32 into main Jun 13, 2024
@janosh janosh deleted the wandb branch June 13, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request training Questions and issues about training the model ux User experience

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@janosh @bowen-bd