Conversation
…cks in CrySLRule and parser - Implemented structured parsing and handling for REFERENCES block via CrySLReferenceEntry - Extended CrySLRule to include collections for references, CWEs (weaknesses), and CVEs (vulnerabilities) - Updated CrySLModelReader to parse and map ReferencesBlock, weaknesses, and vulnerabilities from EMF model - Enhanced test coverage to verify parsing and output for REFERENCES, weaknesses (CWEs), and vulnerabilities (CVEs) - Updated toString() and print methods for clear structured output of references, weaknesses, and vulnerabilities per rule
swissiety
approved these changes
Aug 11, 2025
Comment on lines
+235
to
+237
| String id = cv; | ||
| String link = "https://www.cve.org/CVERecord?id=" + id; | ||
| return new CrySLVulnerabilityEntry(cv, link); |
Collaborator
There was a problem hiding this comment.
we could model this cleaner in a subclass (another PR) only taking the cve number - where CrySLVulnerabilityEntry would then be an interface
Author
There was a problem hiding this comment.
Yes we can do that. I will create a subclass for this then so that CrySLModelReader stays clean.
swissiety
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented WEAKNESS, VULNERABILITIES and REFERENCES in Crysl Syntax with support for page numbers and URLs.