MSAL will use env var MSAL_FORCE_REGION by default#756
Merged
Conversation
c834d8b to
02dd5b7
Compare
bgavrilMS
reviewed
Oct 11, 2024
| 2. ``azure_region="some_region"`` - meaning the specified region is used. | ||
| 3. ``azure_region=True`` - meaning | ||
| MSAL will try to auto-detect the region. This is not recommended. | ||
| 4. ``azure_region=False`` - meaning MSAL will use no region. |
Member
There was a problem hiding this comment.
Not as per spec. Let's please keep it as per spec.
Contributor
Author
There was a problem hiding this comment.
Per offline discussion, an alias DISABLE_MSAL_FORCE_REFRESH is now added here.
bgavrilMS
requested changes
Oct 11, 2024
Member
bgavrilMS
left a comment
There was a problem hiding this comment.
Looks good, but please let's use DisableMsalForceRegion string to be consistent with the other MSALs.
bgavrilMS
approved these changes
Oct 11, 2024
Add an alias DISABLE_MSAL_FORCE_REFRESH for False
65243bf to
33dbe3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
msal/application.pyfile to include a new feature that allows MSAL to use theMSAL_FORCE_REGIONenvironment variable by default. This closes #748Docs are also updated and staged here.