This repository was archived by the owner on Feb 12, 2025. It is now read-only.
Retract adal versions with token refresh errors#716
Merged
jhendrixMSFT merged 2 commits intoAzure:mainfrom Jan 17, 2023
Merged
Conversation
Signed-off-by: Bernd Verst <github@bernd.dev>
RickWinter
reviewed
Jan 13, 2023
Member
RickWinter
left a comment
There was a problem hiding this comment.
This seems reasonable, @jhendrixMSFT can you take a look.
Member
Author
|
Can we update the build pipeline to remove Go 1.15? Then the errors regarding Also, no idea what the |
jhendrixMSFT
approved these changes
Jan 17, 2023
nickysemenza
added a commit
to cloudflare/gokeyless
that referenced
this pull request
Mar 27, 2023
retracted module in Azure/go-autorest#716 causing `go get` to fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bernd Verst github@bernd.dev
This retracts a range of
adallibrary versions which have errors in the handling of Token Refresh calls.These errors can results in a huge range of subtle failures, such as inability to refresh a service principal token obtained via managed identity / MSI.
This retraction does not break builds using this particular version, but will print a warning to anyone impacted.
v0.9.20is the first working version.For this retraction to become effective a new release
v0.9.22(sincev0.9.21is the latest right now) needs to be tagged.