This repository was archived by the owner on Feb 12, 2025. It is now read-only.
Fix validation in resource id parsing#704
Merged
jhendrixMSFT merged 2 commits intoAzure:mainfrom Aug 8, 2022
Merged
Conversation
Member
|
Can you please provide a brief description of what's broken without this fix? |
Contributor
Author
|
@jhendrixMSFT |
jhendrixMSFT
approved these changes
Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.
Before fix, 'ANYSTRING+valid id' can also be parsed as valid id, that's not correct.
As part of submitting, please make sure you can make the following assertions: