[pyAMQP] Add Support For Decimal#39511
Merged
kashifkhan merged 13 commits intoAzure:mainfrom Feb 6, 2025
Merged
Conversation
Collaborator
|
API change check API changes are not detected in this pull request. |
Member
Author
|
/azp run python - servicebus - tests |
Member
Author
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
l0lawrence
reviewed
Feb 3, 2025
swathipil
reviewed
Feb 4, 2025
sdk/eventhub/azure-eventhub/tests/pyamqp_tests/unittest/test_encode.py
Outdated
Show resolved
Hide resolved
edc8100 to
f98b622
Compare
l0lawrence
approved these changes
Feb 6, 2025
l0lawrence
reviewed
Feb 6, 2025
swathipil
approved these changes
Feb 6, 2025
l0lawrence
pushed a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
* add support for decimal128 * decode and encode decimals * clean up * sync EH with changes * unit test for decode decimal * live test * raise error if exponent is incorrect * add a few comments * more unit tests * sync comments to EH * add comment abt dec128 support * fix encode tests
cRui861
pushed a commit
that referenced
this pull request
Feb 27, 2025
* add support for decimal128 * decode and encode decimals * clean up * sync EH with changes * unit test for decode decimal * live test * raise error if exponent is incorrect * add a few comments * more unit tests * sync comments to EH * add comment abt dec128 support * fix encode tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AMQP Spec allows for decimal encoding / decoding. As SB & EH only support Decimal128, that is whats being added over here. The implementation follows the IEEE Std 754-2008 bids formatting and Ive confirmed this works across .net and java on the receiving side properly.
fixes #38717