Merged
Conversation
Collaborator
|
API change check API changes are not detected in this pull request. |
Member
Author
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
API change check API changes are not detected in this pull request. |
1 similar comment
Collaborator
|
API change check API changes are not detected in this pull request. |
Member
Author
|
/azp run python - servicebus - tests |
Member
Author
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
l0lawrence
commented
Jan 14, 2025
sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_client_async.py
Outdated
Show resolved
Hide resolved
l0lawrence
commented
Jan 14, 2025
sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_client_async.py
Outdated
Show resolved
Hide resolved
Member
Author
|
/azp run python - servicebus - tests |
Member
Author
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
5f2a4e6 to
5d0a8a9
Compare
5d0a8a9 to
b5cd28b
Compare
Member
Author
|
/azp run python - eventhub - tests |
Member
Author
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - eventhub - tests |
Member
Author
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
swathipil
reviewed
Jan 23, 2025
sdk/eventhub/azure-eventhub/tests/livetest/asynctests/test_reconnect_async.py
Show resolved
Hide resolved
swathipil
reviewed
Jan 23, 2025
sdk/eventhub/azure-eventhub/tests/livetest/asynctests/test_reconnect_async.py
Show resolved
Hide resolved
kashifkhan
approved these changes
Jan 24, 2025
allenkim0129
pushed a commit
to allenkim0129/azure-sdk-for-python
that referenced
this pull request
Jan 27, 2025
* hardcode to 0 * update * eh * fix reconnect test to reflect retry * remove
l0lawrence
added a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
* hardcode to 0 * update * eh * fix reconnect test to reflect retry * remove
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set retries to 0 to reduce time lag between pyAMQP and uAMQP retries, sdk should still retry 3 times
tests passing
stress tests
Go: a detach gets to the sdk level, which after investigating the error then chooses to retry (reattach link) or not
.NET: a detach is treated in an on-demand context, if the detach happens outside of an operation call it will be retried at the amqp stack level on demand, elsewise it will be handled by the sdk for reattaching/retrying in the context of the operation
In python our send_messages in client.py is wrapped in an amqp level do_retryable_operation. On the other hand our receive operations are not, they only have the capability to be retried at the sdk level. Due to this we at this time cannot implement link-reattach (it would only work for send) without refactoring more code and extensively testing. Creating an issue here to track this.