Skip to content

Suppress codeql#41677

Merged
xiangyan99 merged 1 commit intomainfrom
suppress_codeql
Jun 20, 2025
Merged

Suppress codeql#41677
xiangyan99 merged 1 commit intomainfrom
suppress_codeql

Conversation

@xiangyan99
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reformats specific method calls into multi-line statements to include inline CodeQL suppression comments for backwards compatibility and testing scenarios.

  • Refactored sign_rs256 to a multi-line call with a CodeQL suppression comment.
  • Refactored the XML route test’s error response to a multi-line call with a CodeQL suppression comment.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
sdk/identity/azure-identity/azure/identity/_internal/aadclient_certificate.py Split sign_rs256 return into multiple lines and added CodeQL suppression comment.
sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/test_routes/xml_route.py Split error response return into multiple lines and added CodeQL suppression comment.

@github-project-automation github-project-automation Bot moved this from Untriaged to In Progress in Azure Identity SDK Improvements Jun 20, 2025
@xiangyan99 xiangyan99 merged commit 5fe95ea into main Jun 20, 2025
71 checks passed
@xiangyan99 xiangyan99 deleted the suppress_codeql branch June 20, 2025 20:16
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Azure Identity SDK Improvements Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants