Added broker support for linux & wsl#41624
Merged
xiangyan99 merged 8 commits intomainfrom Jun 24, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends broker support to Linux and WSL, updates the package requirements, and adjusts testing and documentation accordingly.
- Enabled new
enable_broker_on_linuxandenable_broker_on_wslflags in the MSAL client setup. - Dropped Python 3.8 support, added Python 3.13 classifier, and bumped
msal[broker]dependency. - Updated test skip logic and CHANGELOG entries for Linux, WSL, and macOS support.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/azure-sdk-tools/ci_tools/functions.py | Added azure-identity-broker to the PyPy test environment map. |
| sdk/identity/azure-identity-broker/tests/test_broker.py | Changed skip logic to skip only on Linux and updated skip reason. |
| sdk/identity/azure-identity-broker/setup.py | Removed Python 3.8, added 3.13 classifier, bumped Python require, and updated msal[broker] version. |
| sdk/identity/azure-identity-broker/azure/identity/broker/_browser.py | Added enable_broker_on_linux and enable_broker_on_wsl flags for broker support. |
| sdk/identity/azure-identity-broker/CHANGELOG.md | Added entries for Linux & WSL support and Python 3.8 removal. |
Comments suppressed due to low confidence (2)
sdk/identity/azure-identity-broker/CHANGELOG.md:7
- This entry appears outside of a version header—please add a new version section (e.g.,
## 1.4.0 (YYYY-MM-DD)) above these changes and update the date.
- Added broker support for Linux and WSL.
sdk/identity/azure-identity-broker/tests/test_broker.py:17
- There are no tests verifying the new Linux and WSL broker flags (
enable_broker_on_linuxandenable_broker_on_wsl). Consider adding tests that instantiate the credential on those platforms and assert the flags are set correctly.
@pytest.mark.skipif(
pvaneck
reviewed
Jun 20, 2025
Member
pvaneck
left a comment
There was a problem hiding this comment.
Let's add an entry to the README table for Linux and also an entry for the redirect URIs.
pvaneck
reviewed
Jun 20, 2025
pvaneck
approved these changes
Jun 24, 2025
mccoyp
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines