[Identity] Update dev dependencies for broker package#41554
Merged
pvaneck merged 1 commit intoAzure:mainfrom Jun 13, 2025
Merged
[Identity] Update dev dependencies for broker package#41554pvaneck merged 1 commit intoAzure:mainfrom
pvaneck merged 1 commit intoAzure:mainfrom
Conversation
ef5127c to
816ce23
Compare
`pytest-cov` and the latest versions of `cryptography` don't seem to play nice on Python 3.9. Let's just pin cryptography for Python 3.9. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
816ce23 to
ddae348
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR pins the cryptography dependency to <45.0.0 for Python versions below 3.10 to work around pytest-cov import issues on Python 3.9.
- Added version constraint for
cryptographyin dev requirements
Comments suppressed due to low confidence (1)
sdk/identity/azure-identity-broker/dev_requirements.txt:5
- [nitpick] Consider adding a comment above this line explaining why
cryptographyis pinned to <45.0.0 for Python <3.10 (e.g., to avoid the PyO3 import error in pytest-cov on Python 3.9).
cryptography<45.0.0; python_version < "3.10"
xiangyan99
reviewed
Jun 12, 2025
xiangyan99
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the azure-identity-broker project, pytest-cov doesn't seem to like the latest versions of
cryptographyyielding errors like:This has been causing our pipelines to fail for a while, Not sure why exactly, but let's just pin cryptography for Python 3.9.