Merged
Conversation
cac8242 to
e84c079
Compare
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
430ec2c to
0a0918c
Compare
...notation-processor/src/main/java/io/clientcore/annotation/processor/AnnotationProcessor.java
Outdated
Show resolved
Hide resolved
4d6782c to
7e7ecba
Compare
alzimmermsft
reviewed
Mar 6, 2025
sdk/clientcore/annotation-processor-test/src/main/java/module-info.java
Outdated
Show resolved
Hide resolved
...ain/java/io/clientcore/annotation/processor/test/implementation/TestInterfaceClientImpl.java
Show resolved
Hide resolved
...ain/java/io/clientcore/annotation/processor/test/implementation/TestInterfaceClientImpl.java
Show resolved
Hide resolved
...on-processor/src/main/java/io/clientcore/annotation/processor/models/HttpRequestContext.java
Outdated
Show resolved
Hide resolved
...notation-processor/src/main/java/io/clientcore/annotation/processor/utils/TypeConverter.java
Outdated
Show resolved
Hide resolved
...notation-processor/src/main/java/io/clientcore/annotation/processor/utils/TypeConverter.java
Outdated
Show resolved
Hide resolved
srnagar
reviewed
Mar 7, 2025
...ion-processor-test/src/test/java/io/clientcore/annotation/processor/test/RestProxyTests.java
Show resolved
Hide resolved
...ain/java/io/clientcore/annotation/processor/test/implementation/TestInterfaceClientImpl.java
Show resolved
Hide resolved
sdk/clientcore/annotation-processor/checkstyle-suppressions.xml
Outdated
Show resolved
Hide resolved
...notation-processor/src/main/java/io/clientcore/annotation/processor/AnnotationProcessor.java
Show resolved
Hide resolved
...notation-processor/src/main/java/io/clientcore/annotation/processor/AnnotationProcessor.java
Outdated
Show resolved
Hide resolved
...notation-processor/src/main/java/io/clientcore/annotation/processor/AnnotationProcessor.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/clientcore/annotation/processor/templating/JavaParserTemplateProcessor.java
Show resolved
Hide resolved
...annotation-processor/src/main/java/io/clientcore/annotation/processor/utils/PathBuilder.java
Outdated
Show resolved
Hide resolved
8ecdcf3 to
4f1d4d3
Compare
4f1d4d3 to
5fc4915
Compare
alzimmermsft
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ServiceInterfaceto be imported from within theClientImplclass, rather than as a separate class import (TestInterfaceClientImpl.TestInterfaceClientService).CodegenUtilas its methods are no longer needed due to return type updates.getNewInstanceto useHttpPipelineandSerializerinput parameters.entityTypeprocessing in response body handling instead of relying on strings.Coreutilsfor parameterized type creation.ListtoList<String>.Generated Impl
Closes: #44270