Skip to content

Compile-Time codegen updates#44440

Merged
samvaity merged 11 commits intoAzure:mainfrom
samvaity:return-type-fix
Mar 10, 2025
Merged

Compile-Time codegen updates#44440
samvaity merged 11 commits intoAzure:mainfrom
samvaity:return-type-fix

Conversation

@samvaity
Copy link
Copy Markdown
Member

@samvaity samvaity commented Feb 27, 2025

Description

  • Changed return types from fully qualified names to short names.
  • Updated ServiceInterface to be imported from within the ClientImpl class, rather than as a separate class import (TestInterfaceClientImpl.TestInterfaceClientService).
  • Removed CodegenUtil as its methods are no longer needed due to return type updates.
  • Modified getNewInstance to use HttpPipeline and Serializer input parameters.
  • Made miscellaneous updates including adding Javadoc, cleaning up unused methods, and adjusting modifiers.
  • Added entityType processing in response body handling instead of relying on strings.
  • Switched to using Coreutils for parameterized type creation.
  • Fixed generic type method parameter to correctly add generic arguments, changing from List to List<String>.
  • Fix issue where null query parameters are added to the host string.

Generated Impl

Closes: #44270

@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Feb 27, 2025

API change check

APIView has identified API level changes in this PR and created following API reviews.

io.clientcore:core
io.clientcore:annotation-processor

@samvaity samvaity marked this pull request as ready for review March 3, 2025 18:12
@samvaity samvaity force-pushed the return-type-fix branch 2 times, most recently from 430ec2c to 0a0918c Compare March 3, 2025 20:20
@samvaity samvaity force-pushed the return-type-fix branch 2 times, most recently from 4d6782c to 7e7ecba Compare March 5, 2025 20:48
@samvaity samvaity merged commit a3832e6 into Azure:main Mar 10, 2025
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Annotation-processor: Fix fully qualified names in return types

5 participants