Skip to content

Refactor "map2json"#1790

Merged
lvca merged 2 commits intoArcadeData:mainfrom
gramian:warning
Oct 28, 2024
Merged

Refactor "map2json"#1790
lvca merged 2 commits intoArcadeData:mainfrom
gramian:warning

Conversation

@gramian
Copy link
Copy Markdown
Collaborator

@gramian gramian commented Oct 28, 2024 •
edited
Loading

What does this PR do?

These changes fix warnings by refactoring the causing method map2json in the JSONSerializer class. The following changes are included:

The caller changes were minimal, because previously null was passed to signify no includeProperties, which is repurposed to mean type is null for most cases. Only the calls which use both had to be adapted.

Motivation

Originally, these warnings:

[WARNING] /Users/ch/Projects/arcadedb/engine/src/main/java/com/arcadedb/database/MutableDocument.java:[114,80] non-varargs call of varargs method with inexact argument type for last parameter;
  cast to java.lang.String for a varargs call
  cast to java.lang.String[] for a non-varargs call and to suppress this warning
[WARNING] /Users/ch/Projects/arcadedb/engine/src/main/java/com/arcadedb/database/ImmutableDocument.java:[92,74] non-varargs call of varargs method with inexact argument type for last parameter;
  cast to java.lang.String for a varargs call
  cast to java.lang.String[] for a non-varargs call and to suppress this warning
[WARNING] /Users/ch/Projects/arcadedb/engine/src/main/java/com/arcadedb/database/DetachedDocument.java:[86,74] non-varargs call of varargs method with inexact argument type for last parameter;
  cast to java.lang.String for a varargs call
  cast to java.lang.String[] for a non-varargs call and to suppress this warning
[WARNING] /Users/ch/Projects/arcadedb/network/src/main/java/com/arcadedb/remote/RemoteMutableVertex.java:[97,74] non-varargs call of varargs method with inexact argument type for last parameter;
  cast to java.lang.String for a varargs call
  cast to java.lang.String[] for a non-varargs call and to suppress this warning
[WARNING] /Users/ch/Projects/arcadedb/network/src/main/java/com/arcadedb/remote/RemoteImmutableDocument.java:[98,74] non-varargs call of varargs method with inexact argument type for last parameter;
  cast to java.lang.String for a varargs call
  cast to java.lang.String[] for a non-varargs call and to suppress this warning
[WARNING] /Users/ch/Projects/arcadedb/network/src/main/java/com/arcadedb/remote/RemoteMutableDocument.java:[84,74] non-varargs call of varargs method with inexact argument type for last parameter;
  cast to java.lang.String for a varargs call
  cast to java.lang.String[] for a non-varargs call and to suppress this warning
[WARNING] /Users/ch/Projects/arcadedb/network/src/main/java/com/arcadedb/remote/RemoteMutableEdge.java:[99,74] non-varargs call of varargs method with inexact argument type for last parameter;
  cast to java.lang.String for a varargs call
  cast to java.lang.String[] for a non-varargs call and to suppress this warning

motivated the changes.

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@lvca lvca self-requested a review October 28, 2024 23:50
@lvca lvca added this to the 24.11.1 milestone Oct 28, 2024
@lvca lvca added the enhancement New feature or request label Oct 28, 2024
@lvca lvca merged commit c63bb08 into ArcadeData:main Oct 28, 2024
@lvca
Copy link
Copy Markdown
Member

lvca commented Oct 28, 2024

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lvca lvca Awaiting requested review from lvca

Assignees

@gramian gramian

Labels

enhancement New feature or request

Projects

None yet

Milestone

24.11.1

Development

Successfully merging this pull request may close these issues.

2 participants

@gramian @lvca