Skip to content

Escape Quotes in markdown footnotes#90

Merged
jph00 merged 1 commit intomainfrom
quote
Jul 21, 2025
Merged

Escape Quotes in markdown footnotes#90
jph00 merged 1 commit intomainfrom
quote

Conversation

@ncoop57
Copy link
Contributor

@ncoop57 ncoop57 commented Jul 21, 2025

This pull request addresses a bug in the Markdown formatting for footnotes when a quote is present in the footnote citation text. Specifically, this pull request escapes quotes from cited text. To ensure proper Markdown rendering, I also added an example, which has a citation (14) that showcases this escaping working.

@gitnotebooks
Copy link

gitnotebooks bot commented Jul 21, 2025

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/claudette/pull/90

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Citation 14 here showcase the quote escaping working

@ncoop57
Copy link
Contributor Author

ncoop57 commented Jul 21, 2025

@jph00 not sure why this has such a huge diff, the outputs seem to have slightly changed for some reason causing that to happen. Lmk if you know how to avoid this. The function that changed was def blks2cited_txt(txt_blks):

@ncoop57 ncoop57 requested a review from jph00 July 21, 2025 17:22
@jph00
Copy link
Contributor

jph00 commented Jul 21, 2025

Thank you :D (Don't worry about the diff size. I don't think we have reclm enabled here so we get new outputs each time.)

@jph00 jph00 merged commit 2f5960f into main Jul 21, 2025
@jph00 jph00 added the bug Something isn't working label Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants