feat: add bson ObjectId impl#340
Merged
gustavo-shigueo merged 7 commits intoAleph-Alpha:mainfrom Jul 24, 2024
ShaunSHamilton:feat_bson-objectid
Merged
feat: add bson ObjectId impl#340gustavo-shigueo merged 7 commits intoAleph-Alpha:mainfrom ShaunSHamilton:feat_bson-objectid
gustavo-shigueo merged 7 commits intoAleph-Alpha:mainfrom
ShaunSHamilton:feat_bson-objectid
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
The docs suggest the
bson-uuid-implfeature flag implements types frombson. However, this is misleading, because it just implementsTSforbson::Uuid.On top of this, the library suggests there is a
bsonfeature flag. However, enabling this does nothing. So, this pr adds an impl forbson::oid::ObjectIdwhich is a particularly common type.This PR does not expect to implement every exported type from
bson. Hopefully, this will be done in future releases ofts-rs.Related to #186
Changes
bson::oid::ObjectIdimpl underbsonfeature config.bsonfeature flagChecklist
Notes
The docs suggest running
cargo +nightly fmt. However, after running this, unrelated files were changed. So, those have not been pushed.bsonserializesObjectIdinto{ "$oid": <string> }. However, this is likely not what users want in their types.